Correct table html with close tag for </thead> #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kizzie
requested review from
mdlinville,
thaJeztah and
vdemeester
as code owners
kizzie
force-pushed
the
fix/html-for-table
branch
from
51b0a68 to
f4fcabd
Compare
Codecov Report
@@ Coverage Diff @@
## master #784 +/- ##
======================================
Coverage 50.9% 50.9%
======================================
Files 237 237
Lines 15338 15338
======================================
Hits 7808 7808
Misses 7028 7028
Partials 502 502 |
thaJeztah
requested changes
Jan 4, 2018
| port for both protocols, specify the `-p` or `--publish` flag twice. | ||
| </p></td> | ||
| </tr> | ||
|
|
Member
There was a problem hiding this comment.
Can you remove this line change and amend your commit?
Contributor
Author
There was a problem hiding this comment.
Some swearing at text editors adding and removing spaces from ends of lines later - all done
Member
There was a problem hiding this comment.
Oooh, sorry for that, thanks so much for fixing!
kizzie
force-pushed
the
fix/html-for-table
branch
3 times, most recently
from
fe70ad9 to
e9a1cbb
Compare
Signed-off-by: Kat Samperi <kat.samperi@gmail.com>
kizzie
force-pushed
the
fix/html-for-table
branch
from
e9a1cbb to
57372d1
Compare
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
Correct table html with close tag for </thead> Upstream-commit: 2a4c1ef Component: cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently shows as:
on the docker website - missing a close tag for thead (to be honest https://docs.docker.com/engine/reference/commandline/service_create/#publish-service-ports-externally-to-the-swarm--p-publish is a bit of a mess at the moment)
- A picture of a cute animal (not mandatory but encouraged)
(my user pic is one of my bunnies if that helps?)