Skip to content

Conversation

@thaJeztah
Copy link
Member

This code kept being modified by my IDE, so fixing the formatting.

This is auto-generated code, but the code to generate is not in this repository, so this is a temporary fix until the code-generation upstream is fixed :)

ping @vdemeester @silvin-lubecki this is just a temporary fix, but it drove me crazy (I'll have a look at the upstream repo to fix the formatting there)

This code kept being modified by my IDE, so fixing
the formatting.

This is auto-generated code, but the code to generate
is not in this repository, so this is a temporary fix
until the code-generation upstream is fixed :)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io
Copy link

codecov-io commented Jan 3, 2018

Codecov Report

Merging #781 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage    50.9%   50.89%   -0.01%     
==========================================
  Files         237      237              
  Lines       15338    15338              
==========================================
- Hits         7808     7807       -1     
- Misses       7028     7029       +1     
  Partials      502      502

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😇

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this will be fixed in the generator before we need to revendor

@dnephin dnephin merged commit 220c50a into docker:master Jan 4, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Jan 4, 2018
@thaJeztah thaJeztah deleted the fix-autogenerated-formatting branch January 4, 2018 16:39
@thaJeztah thaJeztah modified the milestones: 18.01.0, 18.02.0 Jan 9, 2018
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
…ting

Fix gofmt for auto-generated k8s code
Upstream-commit: 220c50a
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants