cli/command/image: deprecate RunPull and make internal #5975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
impact/changelog
impact/deprecation
status/2-code-review
area/go-sdk
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5975 +/- ##
==========================================
- Coverage 59.14% 59.14% -0.01%
==========================================
Files 355 355
Lines 29738 29740 +2
==========================================
Hits 17590 17590
- Misses 11173 11175 +2
Partials 975 975 🚀 New features to boost your workflow:
|
thaJeztah
changed the title
thaJeztah
force-pushed
the
internalize_image_runsave
branch
from
3a8235e to
58500f4
Compare
thaJeztah
changed the title
thaJeztah
commented
Apr 1, 2025
This function was exported in e43c792 for use of "docker app", which is now deprecated. The signature of this function also depended on a non-exported type so it could not be used externally. Make it internal again, as it was never designed to be exported. There are no known external consumers of this function. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This function was exported in e43c792 for use of "docker app", which is now deprecated. The signature of this function also depended on a non-exported type, so it could not be used externally. Make it internal again, as it was never designed to be exported. There are no known external consumers of this function. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This function was exported in 812f113 for use in other parts of the CLI, but it's now only used locally. Make it internal again, as it was never designed to be exported. There are no known external consumers of this function, but deprecating it first, in case there are. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
internalize_image_runsave
branch
from
58500f4 to
2328745
Compare
Benehiko
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker/cliwith upstream changes docker-archive-public/docker.app#244cli/command/image: un-export RunPush
This function was exported in e43c792
for use of "docker app", which is now deprecated. The signature of this
function also depended on a non-exported type, so it could not be used
externally.
Make it internal again, as it was never designed to be exported. There
are no known external consumers of this function.
cli/command/image: un-export RunSave
This function was exported in e43c792
for use of "docker app", which is now deprecated. The signature of this
function also depended on a non-exported type, so it could not be used
externally.
Make it internal again, as it was never designed to be exported. There
are no known external consumers of this function.
cli/command/image: deprecate RunPull and make internal
This function was exported in 812f113
for use in other parts of the CLI, but it's now only used locally.
Make it internal again, as it was never designed to be exported. There
are no known external consumers of this function, but deprecating it
first, in case there are.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)