Skip to content

Conversation

@thaJeztah
Copy link
Member

Leftover from another branch I was working on 😂

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Mar 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.08%. Comparing base (2b0631f) to head (60645d2).

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5961   +/-   ##
=======================================
  Coverage   59.08%   59.08%           
=======================================
  Files         354      354           
  Lines       29739    29738    -1     
=======================================
  Hits        17572    17572           
+ Misses      11197    11196    -1     
  Partials      970      970           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Transport: authTransport,
Credentials: creds,
Scopes: []auth.Scope{scope},
ClientID: registry.AuthClientID,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one made me wonder; I see we're constructing token handlers in different places; for this one, and some paths in docker/docker, we set the ClientID; https://github.com/moby/moby/blob/330857ad0ffbc8114556f7886997fc43d7be4aad/distribution/registry.go#L123

But in cli/registry/client we use auth.NewTokenHandler

creds := registry.NewStaticCredentialStore(&authConfig)
tokenHandler := auth.NewTokenHandler(authTransport, creds, repoName, actions...)

Which means we end up with github.com/docker/distribution picking a default;

clientID := th.clientID
if clientID == "" {
// Use default client, this is a required field
clientID = defaultClientID
}

Which would be registry-client

const defaultClientID = "registry-client"

@vvoland vvoland merged commit 8e6de54 into docker:master Mar 31, 2025
96 checks passed
@vvoland vvoland added this to the 28.0.5 milestone Mar 31, 2025
@thaJeztah thaJeztah deleted the trust_remove_intermediate_var branch March 31, 2025 12:34
@thaJeztah thaJeztah modified the milestones: 28.0.5, 28.1.0 Apr 10, 2025
@thaJeztah thaJeztah self-assigned this May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants