Skip to content

Conversation

@thaJeztah
Copy link
Member

relates to:

This function was deprecated in 298bddc for v25.0, and unused. This patch removes the function.

- Description for the changelog

cli/command/container: remove deprecated `NewStartOptions()`

- A picture of a cute animal (not mandatory but encouraged)

This function was deprecated in 298bddc for
v25.0, and unused. This patch removes the function.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.63%. Comparing base (f18a476) to head (2402dac).
Report is 806 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4811   +/-   ##
=======================================
  Coverage   59.63%   59.63%           
=======================================
  Files         287      287           
  Lines       24777    24775    -2     
=======================================
  Hits        14775    14775           
+ Misses       9114     9112    -2     
  Partials      888      888           

@thaJeztah thaJeztah requested a review from a team January 22, 2024 20:33
Copy link
Contributor

@krissetto krissetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit ea84a3f into docker:master Jan 23, 2024
@thaJeztah thaJeztah deleted the remove_deprecated_NewStartOptions branch January 23, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants