cli/command/container: waitExitOrRemoved: take APIClient as argument #4453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
kind/refactor
vvoland
approved these changes
Jul 24, 2023
thaJeztah
commented
Jul 24, 2023
thaJeztah
force-pushed
the
small_interface_waitExitOrRemoved
branch
from
fe1651f to
238cc95
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4453 +/- ##
===========================================
+ Coverage 0 59.39% +59.39%
===========================================
Files 0 288 +288
Lines 0 24782 +24782
===========================================
+ Hits 0 14720 +14720
- Misses 0 9175 +9175
- Partials 0 887 +887 |
It only needs the API client, not the whole DockerCLI. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
small_interface_waitExitOrRemoved
branch
from
238cc95 to
7a89e89
Compare
vvoland
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli/command/container: RunStart: inline variable
cli/command/container: waitExitOrRemoved: take APIClient as argument
It only needs the API client, not the whole DockerCLI.
- A picture of a cute animal (not mandatory but encouraged)