Remove registry Service use

[thaJeztah]

• relates to vendor: update docker/docker to master (v24.0.0-dev) #4010
• relates to Move filtered registry search out of the image service moby/moby#45086 (moby/moby@7b3acdf removed the interface, so we can no longer use that).

Looks like the service is not needed, as we always pass an empty config, so we can use ParseRepositoryInfo instead.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[thaJeztah]

We need to check if this is still needed; ISTR this was some snafu on Docker Hub, and may not even be needed anymore. /cc @tianon (ISTR you were on that discussion, but I don't recall the status 🤔)

[tianon]

That's correct! Docker Hub still allows the auth class, but it works fine either way (ie, it is no longer required like it used to be).

[thaJeztah]

If that's the case, perhaps we can remove all of this altogether 🤔 🎉

I tried to be a bit more careful as I'm not even sure this code-path is tested 😬 (plugins are a bit of a corner-case, so it wouldn't surprise me if there isn't a e2e test for this).

[thaJeztah]

Gave that a quick go in #4114 (still in draft; if that variant would work, I can update this PR 😅)

[thaJeztah]

For reference; this is what ParseRepositoryInfo does;

cli/vendor/github.com/docker/docker/registry/config.go

Lines 413 to 432 in 1448258

	// newRepositoryInfo validates and breaks down a repository name into a RepositoryInfo
	func newRepositoryInfo(config *serviceConfig, name reference.Named) (*RepositoryInfo, error) {
	index, err := newIndexInfo(config, reference.Domain(name))
	if err != nil {
	return nil, err
	}
	official := !strings.ContainsRune(reference.FamiliarName(name), '/')
	return &RepositoryInfo{
	Name: reference.TrimNamed(name),
	Index: index,
	Official: official,
	}, nil
	}
	// ParseRepositoryInfo performs the breakdown of a repository name into a RepositoryInfo, but
	// lacks registry configuration.
	func ParseRepositoryInfo(reposName reference.Named) (*RepositoryInfo, error) {
	return newRepositoryInfo(emptyServiceConfig, reposName)
	}

It uses an emptyServiceConfig, which is needed to mark localhost as "insecure", and docker.io as "official"

cli/vendor/github.com/docker/docker/registry/config.go

Line 57 in 1448258

emptyServiceConfig, _ = newServiceConfig(ServiceOptions{})

[thaJeztah]

I was a bit on the fence wether to define this as a type, or to just inline the signature in the function below (like we do for authResolver).

[thaJeztah]

For testing this... if only I could find a plugin with content trust 😂

DOCKER_CONTENT_TRUST=1 docker plugin install --disable vieux/sshfs
Error: remote trust data does not exist for docker.io/vieux/sshfs: notary.docker.io does not have trust data for docker.io/vieux/sshfs
DOCKER_CONTENT_TRUST=1 docker plugin install --disable tiborvass/sample-volume-plugin
Error: remote trust data does not exist for docker.io/tiborvass/sample-volume-plugin: notary.docker.io does not have trust data for docker.io/tiborvass/sample-volume-plugin
DOCKER_CONTENT_TRUST=1 docker plugin install --disable grafana/loki-docker-driver:main
Error: remote trust data does not exist for docker.io/grafana/loki-docker-driver: notary.docker.io does not have trust data for docker.io/grafana/loki-docker-driver
DOCKER_CONTENT_TRUST=1 docker plugin install --disable docker/telemetry
Error: remote trust data does not exist for docker.io/docker/telemetry: notary.docker.io does not have trust data for docker.io/docker/telemetry
DOCKER_CONTENT_TRUST=1 docker plugin install --disable vmware/vsphere-storage-for-docker
Error: remote trust data does not exist for docker.io/vmware/vsphere-storage-for-docker: notary.docker.io does not have trust data for docker.io/vmware/vsphere-storage-for-docker

[thaJeztah]

Closing this in favour of #4114