changed the container name in docker stats page #4027
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> Signed-off-by: Aslam Ahemad <aslamahemad@gmail.com>
Signed-off-by: Aslam Ahemad <aslamahemad@gmail.com>
cpuguy83
approved these changes
Feb 14, 2023
thaJeztah
approved these changes
Feb 14, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
changing the name LGTM (thanks!)
looks like the PR may need a squash and a tiny fix-up for the column. Let me try fix that and push to this PR
| fervent_panini 0.00% 56KiB / 15.57GiB | ||
| 5acfcb1b4fd1 0.07% 32.86MiB / 15.57GiB | ||
| drunk_visvesvaraya 0.00% 0B / 0B | ||
| humble_visvesvaraya 0.00% 0B / 0B |
Member
There was a problem hiding this comment.
We should probably fix the column aligning now (as the new name is 1 character wider)
Member
|
didn't want to force-push to a master branch, so I'm carrying this in #4031 |
Member
|
Thanks @aslamahemad ! Your changes were merged as part of #4031 (they still need to be backported and updated in the docs, so won't be "live" yet on docs.docker.com) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)