Improve bash completion for ulimits #2714
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Several Docker commands have options to create/run a container with special ulimits.
These options take an individual limit as their argument, e.g.
nofile=100.Before this PR, bash completion had no special support for these arguments, treating them as "any string".
See #2712 for the recently added support for ulimits in services.
This change extends the completion part of #2712 and therefore should go into the same Docker release.
- How I did it
Added bash completion for the individual limits after
--ulimit|--ulimit-add|ulimit-rm|default-ulimit.- How to verify it
- Description for the changelog
Improved bash completion for ulimits