-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add ulimits support to docker service and docker stack deploy #2660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ccf5e75 to
b9c148c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2660 +/- ##
==========================================
- Coverage 58.14% 58.12% -0.02%
==========================================
Files 295 295
Lines 21198 21238 +40
==========================================
+ Hits 12325 12345 +20
- Misses 7966 7982 +16
- Partials 907 911 +4 |
|
@thaJeztah This PR is ready for review 😉 |
…cd07 Includes the API changes regarding ulimits support on service endpoints. Signed-off-by: Albin Kerouanton <albin@akerouanton.name>
This is related to moby/moby#40639. Signed-off-by: Albin Kerouanton <albin@akerouanton.name>
This is related to moby/moby#40639. Signed-off-by: Albin Kerouanton <albin@akerouanton.name>
|
Thanks! |
silvin-lubecki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @akerouanton for this PR 👍 The code looks good, but I think this PR lacks some tests. Do you think you could add some to the formater part and to the service update 🙏 ?
|
Just a couple of comments: Need to make sure the final list of ulimits removes duplicates and is sorted. |
|
carried in #2712, thanks! |
- What I did
--ulimittodocker service create;--ulimit-addand--ulimit-rmoptions todocker service update;Ulimitstodocker service inspect --pretty;docker stack deploy;This is related to moby/moby#40639.
- How I did it
- How to verify it
Given the following
docker-compose.yaml:docker service createdocker service updatedocker service inspectdocker stack deploy- Description for the changelog
Add
ulimitssupport todocker service create|update|inspectanddocker stack deploy- A picture of a cute animal (not mandatory but encouraged)