Skip to content

Conversation

@thaJeztah
Copy link
Member

full diff: containerd/continuity@26c1120...efbc448

Relevant changes:

  • sysx/xattr: fix and improve
    • fix getxattrAll: change initial buffer size to 128 to prevent unneeded
      iterations and change the logic to get the real size in case we get ERANGE
      rather than doubling the buffer)
    • improve listxattrAll; refactor for readability, prevent calling listxattr()
      twice. Handle condition when attributes size is changed in between the two
      calls to listxattr().
  • Remove Windows' Readlink fork
    • Drops support for Go 1.12 and under
  • Fix sameFile() to recognize empty files as the same
    • fixes "Empty files can diff as "modified" even when they're not"

…3a899165

full diff: containerd/continuity@26c1120...efbc448

Relevant changes:

- sysx/xattr: fix and improve
    - fix getxattrAll: change initial buffer size to 128 to prevent unneeded
      iterations and change the logic to get the real size in case we get ERANGE
      rather than doubling the buffer)
    - improve listxattrAll; refactor for readability, prevent calling `listxattr()`
      twice. Handle condition when attributes size is changed in between the two
      calls to listxattr().
- Remove Windows' Readlink fork
    - Drops support for Go 1.12 and under
- Fix sameFile() to recognize empty files as the same
    - fixes "Empty files can diff as "modified" even when they're not"

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

Codecov Report

Merging #2657 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2657   +/-   ##
=======================================
  Coverage   58.14%   58.14%           
=======================================
  Files         295      295           
  Lines       21198    21198           
=======================================
  Hits        12325    12325           
  Misses       7966     7966           
  Partials      907      907           

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@thaJeztah thaJeztah merged commit 8a37881 into docker:master Jul 30, 2020
@thaJeztah thaJeztah deleted the bump_continuity branch July 30, 2020 19:40
@thaJeztah thaJeztah added this to the 20.03.0 milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants