Skip to content

Conversation

@albers
Copy link
Collaborator

@albers albers commented Apr 25, 2019

Ref: #1424 (devicemapper), #1425 (overlay)
Deprecated features should not be advertised through completions.

@albers albers added this to the 19.03.0 milestone Apr 25, 2019
@albers albers requested review from thaJeztah and vdemeester April 25, 2019 20:56
@albers albers force-pushed the completion-storage-driver-overlay branch from 0f2e420 to 9f69ff1 Compare April 25, 2019 21:00
@albers albers changed the title Remove deprecated storage driver overlay from bash completion Remove deprecated storage drivers from bash completion Apr 25, 2019
@codecov-io
Copy link

Codecov Report

Merging #1848 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1848   +/-   ##
=======================================
  Coverage   56.75%   56.75%           
=======================================
  Files         309      309           
  Lines       21658    21658           
=======================================
  Hits        12292    12292           
  Misses       8469     8469           
  Partials      897      897

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1848 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1848   +/-   ##
=======================================
  Coverage   56.75%   56.75%           
=======================================
  Files         309      309           
  Lines       21658    21658           
=======================================
  Hits        12292    12292           
  Misses       8469     8469           
  Partials      897      897

@albers albers force-pushed the completion-storage-driver-overlay branch from 9f69ff1 to bfa43d2 Compare April 25, 2019 21:04
Signed-off-by: Harald Albers <github@albersweb.de>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

/cc @andrewhsu

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants