Skip to content

[18.09 backport] Fix bash completion for service update --force #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silvin-lubecki merged 1 commit into from
Nov 21, 2018
Merged

[18.09 backport] Fix bash completion for service update --force #1526

silvin-lubecki merged 1 commit into from
Nov 21, 2018

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Nov 20, 2018

backport of #1521 for 18.09

git checkout -b 18.09_backport_completion_fix_service__force upstream/18.09
git cherry-pick -s -S -x 5fa5eb1da6996ea9cb0249d098ebdf3eb1452b46
git push -u origin

cherry-pick was clean; no conflicts

  • --force is not available in service create
  • --force is a boolean option

@albers @thaJeztah
Fix bash completion for service update --force
046ffa4 
- `--force` is not available in `service create`
- `--force` is a boolean option

Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit 5fa5eb1)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 18.09.1 milestone Nov 20, 2018
@thaJeztah thaJeztah requested a review from albers as a code owner November 20, 2018 17:19
vdemeester
vdemeester approved these changes Nov 20, 2018
View reviewed changes
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@codecov-io
Copy link

codecov-io commented Nov 20, 2018

Codecov Report

Merging #1526 into 18.09 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            18.09    #1526   +/-   ##
=======================================
  Coverage   54.07%   54.07%           
=======================================
  Files         290      290           
  Lines       19394    19394           
=======================================
  Hits        10488    10488           
  Misses       8235     8235           
  Partials      671      671

albers
albers approved these changes Nov 20, 2018
View reviewed changes
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

silvin-lubecki
silvin-lubecki approved these changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 31c092e into docker:18.09 Nov 21, 2018
@thaJeztah thaJeztah deleted the 18.09_backport_completion_fix_service__force branch November 21, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@albers albers albers approved these changes

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

Assignees

No one assigned

Labels

area/completion status/2-code-review

Projects

None yet

Milestone

18.09.1

Development

Successfully merging this pull request may close these issues.

6 participants

@thaJeztah @codecov-io @vdemeester @albers @silvin-lubecki @GordonTheTurtle