Skip to content

Conversation

@tiborvass
Copy link
Collaborator

@tiborvass tiborvass commented Oct 22, 2018

Backport of #1474 for 18.09

Avoid testing for session support in non-buildkit builder to support
servers that falsely report as 1.39 compatible

Signed-off-by: Tibor Vass tibor@docker.com
(cherry picked from commit 3e8c41b)
Signed-off-by: Tibor Vass tibor@docker.com

Avoid testing for session support in non-buildkit builder to support
servers that falsely report as `1.39` compatible

Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit 3e8c41b)
Signed-off-by: Tibor Vass <tibor@docker.com>
@codecov-io
Copy link

Codecov Report

Merging #1475 into 18.09 will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##            18.09    #1475   +/-   ##
=======================================
  Coverage   54.07%   54.07%           
=======================================
  Files         290      290           
  Lines       19391    19391           
=======================================
  Hits        10485    10485           
  Misses       8237     8237           
  Partials      669      669

Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu added this to the 18.09.0 milestone Oct 23, 2018
@andrewhsu andrewhsu merged commit ecb972a into docker:18.09 Oct 23, 2018
@thaJeztah thaJeztah changed the title [18.09] build: update session support detection [18.09 backport] build: update session support detection Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants