Enhancement: don't need to type ssh password twice when docker logs with ssh #1472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lifubang lifubang@acmcoder.com
- What I did
When use ssh host, docker logs need user to type password twice.
- How I did it
Because ContainerInspect is behind ContainerLogs, but ContainerLogs don't close the response, so ContainerInspect can't reuse the connection.
So, move ContainerInspect to the ahead of ContainerLogs.
- How to verify it
- Description for the changelog
Move ContainerInspect to the ahead of ContainerLogs, so we can reuse docker host connection.
- A picture of a cute animal (not mandatory but encouraged)
