builder/prune: rename max-age filter to unused-for in help output #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tibor Vass <tibor@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #1451 +/- ##
======================================
Coverage 54.2% 54.2%
======================================
Files 289 289
Lines 19378 19378
======================================
Hits 10503 10503
Misses 8199 8199
Partials 676 676 |
silvin-lubecki
approved these changes
Oct 17, 2018
Contributor
silvin-lubecki
left a comment
silvin-lubecki
left a comment
There was a problem hiding this comment.
LGTM, by tuhe way did you check if there is any documentation to update too?
Member
|
Looks like there's no documentation yet; https://github.com/docker/cli/tree/master/docs/reference/commandline, so probably we need something as well (can be a follow up) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tibor Vass tibor@docker.com