Skip to content

Conversation

@trapier
Copy link

@trapier trapier commented Oct 10, 2018

- What I did
add bash completion for service {create,update} --no-resolve-image

- How I did it
update contrib/completion/bash/docker:_docker_service_update_and_create()

- How to verify it

bash
source contrib/completion/bash/docker
docker service update <TAB><TAB>
docker service create <TAB><TAB>

- Description for the changelog
NA

@codecov-io
Copy link

codecov-io commented Oct 10, 2018

Codecov Report

Merging #1435 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
+ Coverage    54.2%   54.22%   +0.02%     
==========================================
  Files         289      289              
  Lines       19378    19359      -19     
==========================================
- Hits        10503    10498       -5     
+ Misses       8199     8185      -14     
  Partials      676      676

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :coffee:

Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the contribution. Please update according to my comment.

@albers
Copy link
Collaborator

albers commented Oct 11, 2018

Sorry, I messed up my review comment, so here it is again:

In your implementation, the option requires an argument. Thus, the next option will be treated as an argument to --no-resolve-image and not be completed.
The new option has to be added to the boolean_options variable below.

Signed-off-by: Trapier Marshall <trapier.marshall@docker.com>
@trapier trapier force-pushed the bash_completion_service_no_resolve_image branch from c16eaf3 to 1695eac Compare October 12, 2018 15:03
@trapier
Copy link
Author

trapier commented Oct 12, 2018

🤦‍♂️

good catch @albers!

So moved.

@albers albers merged commit d18aad3 into docker:master Oct 13, 2018
@GordonTheTurtle GordonTheTurtle added this to the 19.03.0 milestone Oct 13, 2018
@albers
Copy link
Collaborator

albers commented Oct 13, 2018

Thanks @trapier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants