-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add bash completion for service --no-resolve-image
#1435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bash completion for service --no-resolve-image
#1435
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1435 +/- ##
==========================================
+ Coverage 54.2% 54.22% +0.02%
==========================================
Files 289 289
Lines 19378 19359 -19
==========================================
- Hits 10503 10498 -5
+ Misses 8199 8185 -14
Partials 676 676 |
vdemeester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :coffee:
albers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the contribution. Please update according to my comment.
|
Sorry, I messed up my review comment, so here it is again: In your implementation, the option requires an argument. Thus, the next option will be treated as an argument to |
Signed-off-by: Trapier Marshall <trapier.marshall@docker.com>
c16eaf3 to
1695eac
Compare
|
🤦♂️ good catch @albers! So moved. |
|
Thanks @trapier. |
- What I did
add bash completion for
service {create,update} --no-resolve-image- How I did it
update
contrib/completion/bash/docker:_docker_service_update_and_create()- How to verify it
- Description for the changelog
NA