Skip to content

Removed unnecessary thinking and force agent to post a comment, even if no issues were found #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgageot merged 1 commit into from
Jan 23, 2026
+11 −5
Merged

Removed unnecessary thinking and force agent to post a comment, even if no issues were found #1488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/agents/pr-review.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ agents:

Find **real bugs in the changed code**, not style issues. If the changed code works correctly, approve it.

## ALWAYS Post a Review

You MUST always post a review via the GitHub API, even if no issues were found.
- If no issues: Post an APPROVE with a brief positive message (e.g., "Looks good! No issues found.")
- If issues found: Post COMMENT or REQUEST_CHANGES with inline comments

Users find it confusing when no review comment is posted - they don't know if the review ran.

## Posting Reviews with Inline Comments

The drafter returns issues in this format:
Expand Down Expand Up @@ -69,7 +77,6 @@ agents:
- type: shell
- type: memory
path: .github/pr-review-memory.db
- type: think

drafter:
model: sonnet
Expand Down Expand Up @@ -143,7 +150,7 @@ agents:
toolsets:
- type: filesystem
tools: [read_file, read_multiple_files, list_directory, directory_tree]
- type: think
- type: think # Keep thinking for bug hypothesis generation

verifier:
model: sonnet
Expand Down Expand Up @@ -181,7 +188,6 @@ agents:
toolsets:
- type: filesystem
tools: [read_file, read_multiple_files, list_directory, directory_tree]
- type: think

permissions:
allow:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:

- name: Process feedback and update memory
if: steps.check.outputs.is_agent_comment == 'true'
uses: docker/cagent-action@7992ea47ed2446b5a80b01c46b00037c680e35ea
uses: docker/cagent-action@latest
with:
agent: ${{ github.workspace }}/.github/workflows/agents/pr-review-feedback.yaml
prompt: |
Expand Down Expand Up @@ -192,7 +192,7 @@ jobs:
echo "EOF" >> $GITHUB_OUTPUT

- name: Run PR Review Team
uses: docker/cagent-action@7992ea47ed2446b5a80b01c46b00037c680e35ea
uses: docker/cagent-action@latest
with:
agent: ${{ github.workspace }}/.github/workflows/agents/pr-review.yaml
prompt: ${{ steps.read-context.outputs.prompt }}
Expand Down
Loading