Fix test race condition with close event#10
Merged
hawkeyexl merged 2 commits intotest-fixesfrom Nov 22, 2025
Merged
Conversation
Merged
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: hawkeyexl <5209367+hawkeyexl@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix race conditions in test execution
Fix test race condition with close event
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test failures in CI due to race condition between Node.js child process
exitandcloseevents. Theexitevent fires before stdio streams flush, causing intermittent failures when output isn't fully captured.Changes
closeevent instead ofexit: Waits for stdio stream closure before resolving, ensuring all output is capturedhandleCompletionguard: Prevents multiple event handlers from racing to resolve/reject the same promise✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.