Fix: Preserve refresh token if not returned in OAuth refresh response#88
Merged
dnplus merged 1 commit intodnplus:mainfrom Jul 7, 2025
Merged
Fix: Preserve refresh token if not returned in OAuth refresh response#88dnplus merged 1 commit intodnplus:mainfrom
dnplus merged 1 commit intodnplus:mainfrom
Conversation
dnplus
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Google OAuth, the refresh response sometimes omits the
refresh_tokenfield. Without preserving the previous refresh token, users may lose the ability to refresh tokens in the future.This PR ensures that if the refreshed token response is missing a
refresh_token, the original one is retained.refresh_tokenin the new token.refresh_tokeninto the new token before returning.This aligns with best practices for OAuth token management, and improves compatibility with Google OAuth.
Closes #87