Skip to content

Expose dtype argument to methods where check_input is an option, add argument to weigh samples#6

Open
PGadoury wants to merge 1 commit intodnhkng:mainfrom
PGadoury:main
Open

Expose dtype argument to methods where check_input is an option, add argument to weigh samples#6
PGadoury wants to merge 1 commit intodnhkng:mainfrom
PGadoury:main

Conversation

@PGadoury
Copy link

@PGadoury PGadoury commented Aug 28, 2025

  • Exposed the dtype argument from _validate_data through the fit, partial_fit, transform and fit_transform methods. This is useful if a specific (e.g. complex) dtype is desired.

  • Added capability to specify X_weights, which reduce (or increase) the importance of a sample during the fit. (this breaks parity with sklearn, but the argument is optional, and I ran the provided tests, which all still work)

  • Added a rudimentary test of the weighted fit. Could use a more sensible set of tests, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant