fix: pass ContentType to COS putObject and ensure charset=utf-8 for text uploads#138
Merged
yujiawei merged 3 commits intodmwork-org:mainfrom Mar 30, 2026
Merged
Conversation
- Add ContentType to putParams in uploadFileToCOS (was missing entirely) - Add ensureTextCharset helper: appends ; charset=utf-8 for text/* types - Apply at both upload call sites (inbound.ts, channel.ts) Fixes dmwork-org#137
086e253 to
4715e31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bot file uploads to COS were missing the
ContentTypeparameter inputObject, causing COS to default toapplication/octet-stream. This made text files (e.g..md) download instead of displaying inline in the browser, and text content appeared garbled due to missing charset.Changes
src/api-fetch.tsContentTypeto COSputObjectparams (the core fix)ensureTextCharset()helper: appends; charset=utf-8totext/*types lacking charsetinferContentType()map with text file extensions:.md,.markdown,.csv,.html,.htm,.css,.xml,.yaml,.ymlsrc/channel.tsapplication/octet-stream, fall back toinferContentType(filename)to get the real typeensureTextCharset()before uploadsrc/inbound.tsensureTextCharset()wrapping for inbound file re-upload pathTests
ensureTextCharsetcovering text types, non-text passthrough, and existing charset preservationCloses #137