Skip to content

Integrate shellcheck as a github action #9788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amaltaro wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Integrate shellcheck as a github action #9788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e345243
Integrate shellcheck as a github action
amaltaro Jul 2, 2020
452b0cc
simple update of wmagent version
amaltaro Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/actions/check_shell_script.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Check Shell Script Syntax

on: [push, pull_request]

jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2.2.0
- name: Get Diff Action
uses: technote-space/get-diff-action@v1.2.8
- name: Install ShellCheck
run: |
sudo apt-get install shellcheck
if: env.GIT_DIFF
- name: Lint with ShellCheck
run: |
shellcheck --shell=bash -x ${{ env.GIT_DIFF }}
if: env.GIT_DIFF
4 changes: 2 additions & 2 deletions deploy/deploy-wmagent.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
### Usage: -c <central_services> Url to central services hosting central couchdb (e.g. alancc7-cloud1.cern.ch)
### Usage:
### Usage: deploy-wmagent.sh -w <wma_version> -d <deployment_tag> -t <team_name> [-s <scram_arch>] [-r <repository>] [-n <agent_number>] [-c <central_services_url>]
### Usage: Example: sh deploy-wmagent.sh -w 1.3.3 -d HG2005b -t production -n 30
### Usage: Example: sh deploy-wmagent.sh -w 1.3.3 -d HG2005b -t testbed-vocms001 -p "9643" -r comp=comp.amaltaro -c cmsweb-testbed.cern.ch
### Usage: Example: sh deploy-wmagent.sh -w 1.3.3.patch4 -d HG2005b -t production -n 30
### Usage: Example: sh deploy-wmagent.sh -w 1.3.3.patch4 -d HG2005b -t testbed-vocms001 -p "9643" -r comp=comp.amaltaro -c cmsweb-testbed.cern.ch
### Usage:

IAM=`whoami`
Expand Down