Html api/add css selector parser #25
Conversation
This is a more appropriate name for the type of match. > `[att|=val]` Represents an element with the att attribute, its value > either being exactly "val" or beginning with "val" immediately > followed by "-" (U+002D). This is primarily intended to allow language > subcode matches (e.g., the hreflang attribute on the a element in > HTML) as described in BCP 47 ([BCP47]) or its successor.
Matches the calling interface for the other HTML API classes, avoids creating the `Generator`, using a static var to avoid re-parsing the selector string instead.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@copilot perform senior-level architectural review over this PR. there is a lot involved so pay attention to a few important aspects:
Task
Leave helpful comments with illustrative examples of how something is wrong or could be better. Cut out the cheekiness and don’t speak cordially. Be machine-like since you are a machine. Before leaving any comment, compute a confidence score in your response. If your response is less than 90% confident then perform a check before answering to confirm some detail. For example, you can imagine the code you want to write, then run sample data through that code and see if it matches your assertion. If it’s less than 60% confident then keep your mouth shut. |
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.