Skip to content

[BUGIFX] Remove construtor arguments for form element nodes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dot3media wants to merge 1 commit into
base: issue_81
Choose a base branch
from
Open

[BUGIFX] Remove construtor arguments for form element nodes #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Classes/Form/Element/ShowDeleteFiles.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,16 @@

class ShowDeleteFiles extends AbstractFormElement
{
protected FileRepository $fileRepository;

protected LanguageService $languageService;

/**
* Container objects give $nodeFactory down to other containers.
*
* @param FileRepository $fileRepository
* @param LanguageService $languageService
*/
public function __construct(
protected readonly FileRepository $fileRepository,
protected readonly LanguageService $languageService
) {
public function __construct() {
$this->fileRepository = GeneralUtility::makeInstance(FileRepository::class);
$this->languageService = $GLOBALS['LANG'];
}

/**
Expand Down
6 changes: 4 additions & 2 deletions Classes/Form/Element/ShowMissingFiles.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,16 @@

class ShowMissingFiles extends AbstractFormElement
{
protected LanguageService $languageService;

/**
* Container objects give $nodeFactory down to other containers.
*
* @param LanguageService|null $languageService
* @throws \InvalidArgumentException
*/
public function __construct(protected readonly LanguageService $languageService)
public function __construct()
{
$this->languageService = $GLOBALS['LANG'];
}

/**
Expand Down