Skip to content

Fix loading fan mode advances after restart and wake-up #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahamid-ha wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix loading fan mode advances after restart and wake-up #288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7358ba9
fix loading fan mode advances after restart and wake
ahamid-ha Dec 28, 2025
c55fa7f
fix wrongly broken indentation
ahamid-ha Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/operate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,7 @@ void Operate::setUserMode(user_mode userMode) const {
fan_mode fanMode = fan_mode::auto_fan_mode;
bool superBattery = false;
QString userModeStr;
Settings s;

switch (userMode) {
case user_mode::balanced_mode:
Expand All @@ -413,6 +414,9 @@ void Operate::setUserMode(user_mode userMode) const {
return;
}

if (s.isValueExist(settingsGroup + "fanModeAdvanced") && s.getValue(settingsGroup + "fanModeAdvanced").toBool())
fanMode = fan_mode::advanced_fan_mode;

if (msiEcHelper.hasShiftMode()) {
msiEcHelper.setShiftMode(shiftMode);
}
Expand Down Expand Up @@ -553,8 +557,22 @@ void Operate::loadSettings() const {

void Operate::handleWakeEvent() const {
Settings s;
if (s.isValueExist(settingsGroup + "fanModeAdvanced"))

// refresh the ec data cache after wakeup
std::ignore = updateEcData();

if (s.isValueExist(settingsGroup + "fanModeAdvanced")) {
setFanModeAdvanced(s.getValue(settingsGroup + "fanModeAdvanced").toBool());

if (s.isValueExist(settingsGroup + "fan1SpeedSettings"))
setFan1SpeedSettings(s.getValueVector(settingsGroup + "fan1SpeedSettings"));
if (s.isValueExist(settingsGroup + "fan2SpeedSettings"))
setFan2SpeedSettings(s.getValueVector(settingsGroup + "fan2SpeedSettings"));
if (s.isValueExist(settingsGroup + "fan1TempSettings"))
setFan1TempSettings(s.getValueVector(settingsGroup + "fan1TempSettings"));
if (s.isValueExist(settingsGroup + "fan2TempSettings"))
setFan2TempSettings(s.getValueVector(settingsGroup + "fan2TempSettings"));
}
}

int Operate::detectFan1Address() const {
Expand Down