Skip to content

Conversation

@hartzell
Copy link

@hartzell hartzell commented Dec 3, 2019

This is a work in progress, not ready to be merged. It might change with feedback from @dmgk and/or the Spack community.


This adds support for generating Spack resource statements, in support of adding general support for Go applications to Spack. It:

  • adds two command line switches (-spack and -app_version)
  • prints Spack resource statements to stdout when -spack is provided on the command line, including a when=... attribute if -app_version is provided.
  • includes tests for general functionality, the inclusion of the when= attribute, and differentiating between the commit= and tag= commit depending on the format of the version identifier.

Closes #7

@dmgk
Copy link
Owner

dmgk commented Dec 3, 2019

LGTM, please let me know when it'll be ready to be merged.

I made a hard fork early, thought I'd cleaned it all up, but missed
these.

Add a test that resolves to a private GitLab repo.
I've reworked the Spack prototype to inhale a JSON array of objects.

This updated the spack output to be, wait for it..., a JSON array of
objects....

With tests.
@hartzell
Copy link
Author

By way of an update, the Spack PR isn't getting timely feedback, so this is on hold until it gets moving again. Thank you for being willing to see the use cases expanded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Working with other packaging systems?

2 participants