RITSAR has exceptions when used with Anaconda 25#6
Open
daniel-anavaino wants to merge 2 commits intodm6718:masterfrom
Open
RITSAR has exceptions when used with Anaconda 25#6daniel-anavaino wants to merge 2 commits intodm6718:masterfrom
daniel-anavaino wants to merge 2 commits intodm6718:masterfrom
Conversation
Changed np.int to np.int64 and np.float to np.float64 as needed. Changed signal.decimate to use a tuple of slices to index the return array (als> Rolled the version to 1.0.1 Updated the README due to setuptools deprections in setup.py and modified the opencv installation instructions. Added a .gitignore file Testing consisted of running all of the examples. There may still be remaining issues with Anaconda 25 in the code.
Fixed numerous index calculations that didn't use integer division. Changed np.int to np.int64 and np.float to np.float64 as needed. Changed signal.decimate to use a tuple of slices to index the return array (also used np.s_ rather than slice objects for readability). Rolled the version to 1.0.1 Updated the README due to setuptools deprecations in setup.py and modified the opencv installation instructions. Added a .gitignore file
Author
|
Two of the examples still have runtime issues: DIRSIG_demo.py dumps a number of QObject::moveToThread messages. simUHF_demo.py has warnings regarding invalid sqrt values as well as QObject::moveToThread messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed numerous index calculations that didn't use integer division.
Changed np.int to np.int64 and np.float to np.float64 as needed.
Changed signal.decimate to use a tuple of slices to index the return array (also used np.s_
rather than slice objects for readability).
Rolled the version to 1.0.1
Updated the README due to setuptools deprecations in setup.py and modified the opencv installation instructions.
Added a .gitignore file