Skip to content

Conversation

@MAM606
Copy link

@MAM606 MAM606 commented Jun 22, 2025

πŸ“Œ Summary

This Pull Request migrates the Android implementation of flutter_tts away from the deprecated PluginRegistry.Registrar API to the modern FlutterPlugin and ActivityAware APIs.

βœ… What Changed

  • Removed deprecated Registrar-based registration.
  • Added FlutterPlugin onAttachedToEngine() binding.
  • Implemented ActivityAware for safer context handling.
  • Maintained backward compatibility with existing usage.

πŸ§ͺ Testing

  • βœ… Verified speaking, pitch, and rate adjustments
  • βœ… Tested on Android physical device (API 33)

πŸ“Ž Related Issue

Closes #592 Issue


Happy to adjust or expand based on feedback. Thank you for maintaining this plugin!

@echogit
Copy link

echogit commented Jul 10, 2025

Are the comments in arabic? Wouldn't english be more broadly understood?

@MAM606
Copy link
Author

MAM606 commented Jul 10, 2025

I become more comfortable with Arabic, and I can describe my codes better in this way, thank you for your feedback. (;

@echogit
Copy link

echogit commented Jul 10, 2025

I become more comfortable with Arabic, and I can describe my codes better in this way, thank you for your feedback. (;

I suggest using AI to translate :P

@dlutton
Copy link
Owner

dlutton commented Aug 30, 2025

@MAM606 please update the comments to English and I'll merge this in

@dlutton dlutton self-assigned this Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal] Migrate Android plugin implementation to modern FlutterPlugin API

3 participants