Allow parsing timestring at different timezones.#58
Allow parsing timestring at different timezones.#58knobo wants to merge 2 commits intodlowe-net:masterfrom
Conversation
|
Better like this? |
knobo
changed the title
| (parse-timestring "2016-12-01" :offset nil) ;; Use default timezone | ||
| (parse-timestring "2016-12-01" :offset (* 60 60 -5)) ;; Ignore timezone | ||
| (parse-timestring "2016-12-01" :offset (* 60 60 -5) :timezone utc-leaps) ;; Ignore timezone | ||
| (parse-timestring "2016-12-01" :offset nil :timezone eastern-tz) ;; Use timezone |
There was a problem hiding this comment.
This should be wrapped in a (let ((default-timezone +utc-zone+)) ...) because you're not actually testing here that the timezone used is different from the default.
There was a problem hiding this comment.
If this were in UTC zone, parse-timestring might change such that :offset nil would be interpreted as :offset 0 regardless of the *default-timezone*, whereas this code tests that :offset nil uses *default-timezone*.
There was a problem hiding this comment.
Wow, I've let this PR seriously languish. Sorry.
I mean that by setting default-timezone to eastern-tz and carefully arranging the arguments so that they return the same timestamps, this test basically doesn't show that the arguments do anything at all. A version of parse-timestring that ignored all its arguments and only used default-timezone would pass this test.
| (parse-timestring "2016-12-01" :offset (* 60 60 -5)) ;; Ignore timezone | ||
| (parse-timestring "2016-12-01" :offset (* 60 60 -5) :timezone utc-leaps) ;; Ignore timezone | ||
| (parse-timestring "2016-12-01" :offset nil :timezone eastern-tz) ;; Use timezone | ||
| (adjust-timestamp (parse-timestring "2016-12-01" :offset nil :timezone utc-leaps) (offset :hour +5)) ;; Use different timezone |
There was a problem hiding this comment.
This line seems more of a test of adjust-timestamp.
| (new (timestamp+ old 24 :hour eastern-tz))) | ||
| (is (= (* 24 60 60) (timestamp-difference new old))))) | ||
|
|
||
| (deftest test/timezone/parse-timestring-different-timezones () |
There was a problem hiding this comment.
You're testing timezones but only using date timestamps? That seems odd.
dlowe-net
left a comment
dlowe-net
left a comment
There was a problem hiding this comment.
I don't even know how to github anymore.
3 participants
Allow parse-timestring to parse timestring in different timezones. This would be useful in cases where timezone is sent separately like it could (and often does) in the icalendar format.
As discussed in #56