Disable Renovate automerge to prevent broken builds#720
Merged
Conversation
Renovate updated System.Collections.Immutable package from 8.0.0 to 10.0.1, but the assembly binding redirect was not updated, causing test failures. Updated the binding redirect from 8.0.0.0 to 10.0.0.0 to match the new package version.
This ensures binding redirects are automatically generated at build time, which helps keep the app.config up-to-date with package dependencies. While this doesn't update the source app.config, it will generate correct redirects in the output folder during builds.
Changed automerge from true to false to prevent Renovate from automatically merging PRs that may have broken builds due to missing binding redirect updates. This ensures that all PRs go through CI checks before being merged, and developers can manually update binding redirects in app.config when needed.
Build Failed ❌Version: 25.52.6.571 📊 Test results are available in the build artifacts |
… version 8.0.0.0 The NuGet package version (10.0.1) doesn't match the assembly version embedded in the DLL (8.0.0.0). Microsoft maintains assembly version stability for backward compatibility even as package versions increase. Updated the binding redirect to: - oldVersion: 0.0.0.0-10.0.0.0 (accept any version up to 10.x) - newVersion: 8.0.0.0 (the actual assembly version in the DLL)
Build Failed ❌Version: 25.52.6.572 📊 Test results are available in the build artifacts |
Testing if NuGet package 10.0.1 uses assembly version 9.0.0.0. Microsoft sometimes uses N-1 assembly versioning for compatibility.
Build Failed ❌Version: 25.52.6.573 📊 Test results are available in the build artifacts |
System.Collections.Immutable 10.0.1 is not compatible with .NET Framework 4.8. Tested assembly versions 10.0.0.0, 9.0.0.0, and 8.0.0.0 - all failed with FileLoadException. This suggests the package itself has compatibility issues with .NET Framework 4.8. Changes: - Reverted System.Collections.Immutable from 10.0.1 to 8.0.0 (last known working version) - Updated binding redirect to match: 8.0.0.0 - Locked System.Collections.Immutable in Renovate to prevent future updates - Removed manual System.Runtime.CompilerServices.Unsafe binding redirect (AutoGenerateBindingRedirects handles it) This resolves the test failures and prevents Renovate from breaking the build again.
Build Complete ✅Version: 25.52.6.574 📊 Test results are available in the build artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.