Skip to content

[fix] DLQ to handle bytes key properly#19

Open
dlg99 wants to merge 1 commit intomasterfrom
dlq_bytes
Open

[fix] DLQ to handle bytes key properly#19
dlg99 wants to merge 1 commit intomasterfrom
dlq_bytes

Conversation

@dlg99
Copy link
Owner

@dlg99 dlg99 commented Aug 14, 2024

Motivation

DLQ producer implicitly converts byte[] key into a bas64-encoded string representing that byte array.

Modifications

Handling setting of keys that are hasBase64EncodedKey() differently.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added a unit test.

Does this pull request potentially affect one of the following parts:

NO

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant