Skip to content

Conversation

@rikkimax
Copy link
Contributor

This is in response to: #22371

Improve the error message so that we get the location of the suggested symbol.

I don't think that I've got this as good as it should be. @Iskaban10 @thewilsonator

image

The only reason I'm PR'ing it now is I suspect that I won't make it be better than this.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @rikkimax! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22372"

@rikkimax rikkimax force-pushed the improve-on-undefined-but-match branch 2 times, most recently from 2919fae to ad615dd Compare January 10, 2026 11:50
@rikkimax rikkimax changed the title Improve error message when symbol lookup fails, show what the suggested symbol is located at Improve error message when symbol lookup fails, show where the suggested symbol is located at Jan 10, 2026
@rikkimax rikkimax force-pushed the improve-on-undefined-but-match branch from ad615dd to f125257 Compare January 10, 2026 12:06
@rikkimax rikkimax force-pushed the improve-on-undefined-but-match branch from f125257 to e21ff5e Compare January 10, 2026 12:14
@rikkimax rikkimax marked this pull request as ready for review January 10, 2026 13:07
@thewilsonator thewilsonator merged commit c75a668 into dlang:master Jan 11, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants