Skip to content

Updates to resolve dartsass deprecation warnings #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkniffin merged 3 commits into from
Feb 3, 2025
Merged

Updates to resolve dartsass deprecation warnings #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ff66bc
Updates to resolve dartsass deprecation warnings
dkniffin Jan 10, 2025
ae358c8
Update the setup-ruby version that runs in the github action
dkniffin Feb 3, 2025
245fdab
Add concurrent-ruby
dkniffin Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/rubyonrails.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
uses: actions/checkout@v4
# Add or replace dependency steps here
- name: Install Ruby and gems
uses: ruby/setup-ruby@55283cc23133118229fd3f97f9336ee23a179fcf # v1.146.0
uses: ruby/setup-ruby@v1
with:
bundler-cache: true
# Add or replace database setup steps here
Expand Down
1 change: 1 addition & 0 deletions activeadmin_reorderable.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,5 @@ Gem::Specification.new do |s|
s.add_development_dependency "selenium-webdriver", '~> 4.10'
s.add_development_dependency "sqlite3", "~> 1.4"
s.add_development_dependency "sassc-rails"
s.add_development_dependency "concurrent-ruby", "1.3.4"
end
5 changes: 4 additions & 1 deletion app/assets/stylesheets/activeadmin_reorderable.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
@use "@activeadmin/activeadmin/src/scss/mixins/all" as *;

.aa-reorderable {
.reorder-handle {
@include light-button;
cursor: move;

@include light-button;
}

.dragged-row {
Expand Down
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,7 @@
"license": "MIT",
"scripts": { },
"devDependencies": { },
"dependencies": { }
"dependencies": {
"@activeadmin/activeadmin": "^3.2.0"
}
}