Added rudimentary platform detection to CMakeLists.txt#151
Open
spillner wants to merge 2 commits intodjyt:masterfrom
Open
Added rudimentary platform detection to CMakeLists.txt#151spillner wants to merge 2 commits intodjyt:masterfrom
spillner wants to merge 2 commits intodjyt:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed this so non-Windows users don't need to manually edit CMakeLists or pass a -DTARGET= every time. The RPi detection (just looking for a GCC-style -march=arm in CMAKE_CXX_FLAGS) is pretty rudimentary (not necessarily what users on other ARM platforms are looking for, and won't detect cross-compilation on non-GCC toolchains), but at least it (a) provides a warning message to show the inferred platform, and (b) doesn't create any more inconvenience than the old "assume Windows 64" behavior did.