fix iframe resize #297
Open
fix iframe resize #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issues #283 and #191.
Because iframe.js and index.js functions are all put on window, iframe.js was actually calling postMessage function in index.js, which clobbered the actual window.postMessage. The parent function just then sent the message back to the child, so it was not receiving any events.
Fixed by renaming parent function. All code should be in IIFEs to prevent this whole class of errors, but this broke the code entirely and so would need to investigate further to do that.
Also just added object sanity check to window.CUSDIS assignment in the two files so they didn't overwrite each other.