Skip to content

Fix process crash after failing to send emails. #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
losfair wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix process crash after failing to send emails. #148

losfair wants to merge 1 commit into from

Conversation

@losfair
Copy link
Contributor

@losfair losfair commented Oct 22, 2021

The call to this.emailService.send is missing an await so exceptions thrown from send terminate the node process.

@vercel
Copy link

vercel bot commented Oct 22, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @djyde on Vercel.

@djyde first needs to authorize it.

@losfair losfair force-pushed the upstream-patch-email-send-failure branch from 5310186 to fb7c758 Compare October 22, 2021 04:30
losfair added a commit to losfair/cusdis that referenced this pull request Nov 21, 2021
@losfair
Merge djyde#148.
ad27136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@losfair