Skip to content

enhancements for the reply form #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
egoist wants to merge 2 commits into
base: master
Choose a base branch
from
Open

enhancements for the reply form #115

egoist wants to merge 2 commits into from

Conversation

@egoist
Copy link
Contributor

@egoist egoist commented May 28, 2021

  • fix for attribute, adding id attribute to input elements
  • use native required attribute

@vercel
Copy link

vercel bot commented May 28, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @djyde on Vercel.

@djyde first needs to authorize it.

djyde
djyde reviewed May 28, 2021
View reviewed changes
widget/components/Reply.svelte
<label class="mb-2 block dark:text-gray-200" for="cusdis_email">{t('email')}</label>
<input
name="email"
id="cusdis_email"
Copy link
Owner

@djyde djyde May 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be t('email')?

Copy link
Contributor Author

@egoist egoist May 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an id 😢

losfair added a commit to losfair/cusdis that referenced this pull request Nov 21, 2021
@losfair
Merge djyde#115.
fa048a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djyde djyde djyde left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@egoist @djyde