Fix base_url assignment in client initialization #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes incorrect assignment logic for
base_urlduringClientinitialization. Ensures that the explicitly providedbase_urlparameter takes priority instead of reassigning from an uninitializedself.base_url.Related Issue(s)
N/A
Changes Made
Corrected
base_urlassignment so that:is used instead of mistakenly referencing
self.base_url.No additional documentation or tests needed for this minimal fix.
Testing
Clientwith/without custombase_urlto confirm expected behavior.Checklist
ruff,isort, optionallyblack).cookbookmodule. (Not needed for minor logic fix)Additional Notes
This prevents potential bugs in SDK usage when client configuration relies on custom endpoints.
Tag
@sudoping01for review.Thanks for contributing to Djelia Python SDK! ❤️🇲🇱