Skip to content

Conversation

@sudoping01
Copy link
Collaborator

Pull Request

Description

Fixes incorrect assignment logic for base_url during Client initialization. Ensures that the explicitly provided base_url parameter takes priority instead of reassigning from an uninitialized self.base_url.

Related Issue(s)

N/A

Changes Made

  • Corrected base_url assignment so that:

    self.base_url = base_url

    is used instead of mistakenly referencing self.base_url.

  • No additional documentation or tests needed for this minimal fix.

Testing

  • Manually instantiated Client with/without custom base_url to confirm expected behavior.
  • All tests pass and no linting errors detected.

Checklist

  • Code follows style guidelines (ruff, isort, optionally black).
  • Tests added or updated in the cookbook module. (Not needed for minor logic fix)
  • Documentation updated (N/A).
  • All tests pass.
  • No linting errors.

Additional Notes

This prevents potential bugs in SDK usage when client configuration relies on custom endpoints.

Tag @sudoping01 for review.
Thanks for contributing to Djelia Python SDK! ❤️🇲🇱

@sudoping01 sudoping01 merged commit f21981c into main Jan 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants