Fixes redic-pool incompatabilty with latest ohm version (2.3.0)#5
Fixes redic-pool incompatabilty with latest ohm version (2.3.0)#5rwrede wants to merge 13 commits intodjanowski:masterfrom
Conversation
- .. to make redic-pool compatible with latest Ohm version (2.3.0)
- fixes loading gem dependency for connection_pool
- should resolve the following error when bundling on travis: There was a LoadError while loading redic-pool.gemspec: cannot load such file -- connection_pool
|
@djanowski, if you are ok with adding travis support you might want to add the travis badge to the README after enabling travis support on Travis CI for your repo. |
|
Also noticed the build on Travis CI to be a bit unstable because, it seems, sometimes the open connection are < 10, e.g. only 8. Maybe you have an idea on how to improve the specs. |
|
@djanowski any chance you could look at this PR please ? |
|
@rwrede This patch is not correct. Redic::Pool#call! should delegate to Redic#call!, not Redic::Pool#call. Ohm expects I know this is an old PR and a lot has probably changed over the past two years, but generally speaking, you may have better luck getting PRs looked at if you break them into smaller pieces, e.g. one PR for the gemspec/Gemfile changes, one PR to add Travis, and one PR for All that being said, it looks like this project is dead, which is unfortunate because it appears to be the only sane option for using Redic and Ohm in a multithreaded environment (in my case, Puma and Sidekiq) with connection pooling. So none of that matters. I'm looking at maintaining my own fork until @djanowski makes his triumphant return! |
Redic#call!(bang method). In order to conform to that new expected API this method was also added toRedic::Poolin this PR. After this PR is merged it should be possible to use redic-pool with ohm 2.3.0.