Skip to content

Refactor queue/commit to reflect Redic's internals. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mwpastore wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor queue/commit to reflect Redic's internals. #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions lib/redic/pool.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,15 @@ class Redic::Pool
def initialize(url, options = {})
@url = url
@pool = ConnectionPool.new(size: options.fetch(:size, 10)) { Redic.new(url) }
@buffer = Hash.new { |h, k| h[k] = [] }
end

def buffer
@buffer[Thread.current.object_id]
end

@id = "redic-pool-#{object_id}"
def reset
@buffer.delete(Thread.current.object_id)
end

def call(*args)
Expand All @@ -21,21 +28,15 @@ def call(*args)
end

def queue(*args)
Thread.current[@id] || (Thread.current[@id] = [])
Thread.current[@id] << args
buffer << args
end

def commit
@pool.with do |client|
Thread.current[@id].each do |args|
client.queue(*args)
end

result = client.commit

Thread.current[@id].clear

result
client.buffer.concat(buffer)
client.commit
end
ensure
reset
end
end