fix: Add validation for WebSocket subprotocols #565
+11
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
ws_protocol.pymodule does not validate thesec-websocket-protocolheader, which can lead to malformed subprotocol lists being passed to the ASGI application. This can cause unexpected behavior and runtime errors if the application is not prepared to handle non-string or otherwise invalid subprotocol values.This update introduces validation for WebSocket subprotocols to prevent potential runtime errors and improve the robustness of the server.
These changes ensure that Daphne handles malformed
sec-websocket-protocolheaders gracefully, making the server more resilient and preventing potential application-level errors.