Skip to content

Only look up slug on download fail #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1JackBlack1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Only look up slug on download fail #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions curseforge_file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,16 +87,15 @@ func (f CurseForgeModFile) install(pack *ModPack) error {
pack.modCache.CleanupModFile(f.projectID)
}

// Resolve the project ID into a slug
slug, err := pack.db.findSlugByProject(f.projectID)
if err != nil {
return fmt.Errorf("failed to find slug for project %d: %+v", f.projectID, err)
}

// Now, retrieve the JSON descriptor for this file so we can get the CDN url
descriptorUrl := fmt.Sprintf("https://addons-ecs.forgesvc.net/api/v2/addon/%d/file/%d", f.projectID, f.fileID)
descriptor, err := getJSONFromURL(descriptorUrl)
if err != nil {
// Resolve the project ID into a slug
slug, err2 := pack.db.findSlugByProject(f.projectID)
if err2 != nil {
return fmt.Errorf("failed to find slug and download url for project %d: %+v\n%+v", f.projectID, err, err2)
}
return fmt.Errorf("failed to retrieve descriptor for %s: %+v", slug, err)
}

Expand Down