Skip to content

Compatibility with p5 v0.7.2 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jwdunn1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Compatibility with p5 v0.7.2 #6

jwdunn1 wants to merge 2 commits into from

Conversation

@jwdunn1
Copy link

@jwdunn1 jwdunn1 commented Oct 30, 2018 •
edited
Loading

Fix for issue #5
renderer.camera() moved down to renderer._curCamera.camera()

Note: All examples will need to be updated to link to p5 v0.7.2

See also: processing/p5.js#3063

@mizunno
Copy link

mizunno commented Aug 6, 2019

Any update?

pablinos
pablinos reviewed May 26, 2020
View reviewed changes
Copy link

@pablinos pablinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came to this via #5 as I was hitting the same problem. The fix works for me as it has for other people so it would be great to get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pablinos pablinos pablinos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jwdunn1 @mizunno @pablinos