Move to rustfmt nightly #4284
Open
Move to rustfmt nightly #4284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgeoghegan
reviewed
Jan 22, 2026
| - name: Install ripgrep | ||
| run: sudo apt-get update && sudo apt-get install -y ripgrep | ||
| - name: Install nightly rustfmt | ||
| run: rustup toolchain install nightly --component rustfmt |
Contributor
There was a problem hiding this comment.
The previous "Install Rust toolchain" step already installs rustfmt, so I think this should be resolved against it. Does anything bad happen if we rustup install on top of what dtolnay/rust-toolchain does? Can dtolnay/rust-toolchain install a nightly rustfmt but stable clippy and rustc for us in one step?
Contributor
Author
There was a problem hiding this comment.
Ooh, I'll look into that!
Collaborator
There was a problem hiding this comment.
The rust-toolchain action does call rustup default ..., so maybe we should just run it twice, with the stable one second, and a different set of components for each.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to #4262 and mostly implements #3056. In three commits it:
ripgrepwithrustfmt nightlyfor comment length enforcmentimports_granularitysetting atCrateand applies it.group_importssetting atStdExternalCrateand applies it.I did not include #3056's suggestion for
format_stringsthough I've confirmed it compiles and tests fine. I did not because unlike the above changes, it sharply diverges from non-nightlyrustfmtand if you format one to the other, everything gets clobbered repeatedly.I think we should take
format_stringsas a follow-on. Besides, it touches a lot of places and would crazily clutter this PR.