Allow disabling ISOs in deployment script #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a list of items to include for the distributed version, we no longer have a good reason to collect all items into a tmp folder and upload it recursively. Doing so uses - more lines of code (cp to folder, then cp to S3), - more time (copy large files on disk), - more disk space (duplicated files). While the awscli S3 client parallelizes uploads, this already happens when invoked for a single file of substantial size (concurrent upload of multipart chunks)[^1] and this should max out the connection. So we seem to have only downsides and no benefits from collecting into a local directory first. [^1]: https://docs.aws.amazon.com/cli/latest/topic/s3-config.html#multipart-chunksize
This automates two simple checks that act as sanity checks that the deployed version truly went "live". They were previously part of a manual release checklist, but can be easily checked by a computer. Because they run after the deployment there seems to be no sense in failing the script, but the verification outcome is color coded to stand out.
Collaborator
Drive-by-comment: normalize this with a |
Member
Author
Could consider, yes. Also thought of a verbose mode, in which it includes all items in the summary. |
Member
Author
Added this, it only skips uploads during dry-run and actually performs any local operations like signing, so one can check that it works. Also added a verbose option. |
Member
Author
|
Building with options akin to Checks fail, because
|
dividat-jgu
reviewed
Jan 26, 2026
Contributor
dividat-jgu
left a comment
dividat-jgu
left a comment
There was a problem hiding this comment.
Good change! Testing it out now, having trouble building develop for the moment.
| else: | ||
| print(f"\033[91mFAIL\033[0m [{description}] Expected {expected}, got {actual}") | ||
| except Exception as e: | ||
| print(f"\033[91mFAIL\033[0m [{description}] Exception: {e}") |
Contributor
There was a problem hiding this comment.
Nitpick: create small helpers for color codes? Like colorizeSuccess(txt: str) -> str and colorizeError(txt: str) -> str.
Member
Author
There was a problem hiding this comment.
I decided not to, because there's not lots of duplication right now, but I also don't mind adding it.
Contributor
There was a problem hiding this comment.
It’s a bit hard to see at a glance the message, or if there is an error with the codes.
Member
Author
There was a problem hiding this comment.
A bit on the edge, but maybe it's worth it:
dividat-jgu
reviewed
Jan 26, 2026
dividat-jgu
added
changes suggested
To avoid manually optimizing for existing or absent slashes in path fragments, use a helper that strips and adds slashes appropriately. Similar functions exist in Python stdlibs, but are not quite right: - https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urljoin performs relative path resolution instead of just joining - https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.joinpath is sensitive to leading slashes (absolute paths) in parts
knuton
added
reviewable
Contributor
|
✔️ Skipping isos doesn’t create links in |
dividat-jgu
reviewed
Jan 27, 2026
It's not a status, and it doesn't follow the same format. Retreating to a simple print before ending up with an AbstractPrintStatusProxyBeanFactory.
Lay out development plan section closer to other sections.
dividat-jgu
approved these changes
Jan 27, 2026
Contributor
dividat-jgu
left a comment
dividat-jgu
left a comment
There was a problem hiding this comment.
Looking good, deploy to develop after the PR has been merged?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by wanting to make
deploy-updaterespectbuildLiveandbuildInstaller(avoiding to build and publish ISOs), along the wayTesting
Handy diff to inspect what script would do:
Checklist