Use checkVisibility when filtering for focusables #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knuton
force-pushed
the
use-checkvisibility
branch
5 times, most recently
from
dd157c2 to
28267ac
Compare
`Element.checkVisibility()` is now available in latest versions of all major browsers. Where it is not available, we can at least roughly approximate it by recursing up the DOM tree and checking for close analogues of the evaluated style properties. This also factors in the recent `content-visibility` CSS property where supported and used.
knuton
force-pushed
the
use-checkvisibility
branch
from
28267ac to
964a85d
Compare
yfyf
approved these changes
Nov 3, 2025
Contributor
yfyf
left a comment
yfyf
left a comment
There was a problem hiding this comment.
Nicely done. Tested that this fixes the issues with exhausted event not firing I saw earlier on a bunch of "messy" websites and also in PlayOS settings. Also briefly checked that it doesn't change/break anything obvious in Play.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element.checkVisibility()is now available in latest versions of all major browsers. Where it is not available, we can at least roughly approximate it by recursing up the DOM tree and checking for close analogues of the evaluated style properties.This is a better check for whether elements should count as "visible" and able to receive focus, because it factors in visibility of ancestors. The check is cheap on modern browsers, older browsers have to pay a slightly bigger tax to determine visibility now.
https://developer.mozilla.org/en-US/docs/Web/API/Element/checkVisibility