Feat new push notification approach by igorgsduarte · Pull Request #25 · ditointernet/sdk_mobile_flutter

igorgsduarte · 2025-05-22T17:48:40Z

O intuito desta Pull Request é aprimorar a push notification, modificando a estrutura de envio para o Android considerando o formato comum de um evento push, contendo a propriedade notification.
Com isso, todos os eventos esperados pela Dito já são emitidos automaticamente, sem a necessidade de intervenção via código, simplificando o uso da SDK.

- Added flutter_dotenv dependency for environment variable management. - Updated notification service to handle messages without body. - Created DEVELOPER_SETUP.md for setup instructions. - Added MIGRATION.md for migrating to the new push structure. - Included necessary configuration files for Firebase (iOS and Android). - Updated .gitignore to exclude build directories.

…orrections

Copilot

Pull request overview

This PR refactors the push notification system to simplify integration by automatically handling notification events without requiring manual code intervention. The changes modify the Android push notification structure to follow a standard event format with a notification property, and flatten the data payload structure for easier access.

Changes:

Simplified push notification initialization by removing the onTap callback parameter and introducing an onClick property
Flattened DataPayload structure by removing the nested Details class and promoting fields to top-level
Automatic event tracking for received notifications without manual intervention
Updated documentation with comprehensive migration guides and developer setup instructions

Reviewed changes

Copilot reviewed 14 out of 17 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
package/pubspec.yaml	Version bump to 0.5.8 and updated flutter_local_notifications constraint
package/lib/services/notification_service.dart	Major refactoring of notification handling, automatic event tracking, and simplified initialization
package/lib/entity/data_payload.dart	Flattened structure with renamed fields (identifier→user_id, notification_log_id→log_id)
package/lib/dito_sdk.dart	Simplified initialization by removing Firebase setup and onTap parameter
package/README.md	Complete documentation rewrite with improved examples and API reference
README.md	Root readme updated matching package readme
MIGRATION.md	New comprehensive migration guide for upgrading to new structure
DEVELOPER_SETUP.md	New developer onboarding documentation
example/*	Updated example app to demonstrate new initialization approach
example/ios/Runner/AppDelegate.swift	Added iOS notification center delegate configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

package/lib/services/notification_service.dart

Copilot · 2026-01-12T20:59:07Z

package/lib/services/notification_service.dart

+  _setupNotifications() async {}



The _setupNotifications method is now empty but still exists. Consider removing this method entirely since it serves no purpose.

Suggested change

_setupNotifications() async {}

Copilot · 2026-01-12T20:59:07Z

package/lib/services/notification_service.dart

+      final data = DataPayload.fromJson(jsonDecode(message.payload!));



Potential null pointer exception: If message.payload is null, this will crash with a null check error when trying to use the ! operator. Consider adding a null check before attempting to decode the payload.

Suggested change

final data = DataPayload.fromJson(jsonDecode(message.payload!));

final payload = message.payload;

if (payload == null) {

return;

}

final data = DataPayload.fromJson(jsonDecode(payload));

package/lib/services/notification_service.dart

Copilot · 2026-01-12T20:59:08Z

example/ios/Runner/AppDelegate.swift

+    if #available(iOS 10.0, *) {
+        UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate
+        }
+
+        func userNotificationCenter(_ center: UNUserNotificationCenter, willPresent notification: UNNotification, withCompletionHandler completionHandler: @escaping (UNNotificationPresentationOptions) -> Void) {
+                         completionHandler([.alert, .badge, .sound])
+          }


The indentation in the Swift code is inconsistent. Lines 11-16 have incorrect indentation, with the closing brace on line 12 and the function definition on lines 14-16 being nested inside the if statement when they should be at the class level. This will cause the userNotificationCenter method to be defined locally within the application method, which is incorrect.

Copilot · 2026-01-12T20:59:09Z

package/README.md

-() async;
+DitoSDK dito = DitoSDK();  
+dito.initialize(apiKey: ditoApiKey, secretKey: ditoSecretKey);  
+await dito.initializePushNotificationService(); //está linha é necessário se for utilizar o serviço de push notification, aqui é feito o registro automático dos eventos de push;


Grammar error: "está" should be "esta" (without accent). The correct phrase is "esta linha é necessária".

Suggested change

await dito.initializePushNotificationService(); //está linha é necessário se for utilizar o serviço de push notification, aqui é feito o registro automático dos eventos de push;

await dito.initializePushNotificationService(); // esta linha é necessária se for utilizar o serviço de push notification, aqui é feito o registro automático dos eventos de push;

Copilot · 2026-01-12T20:59:09Z

README.md

-Future<http.Response> identifyUser() async;
+DitoSDK dito = DitoSDK();  
+dito.initialize(apiKey: ditoApiKey, secretKey: ditoSecretKey);  
+await dito.initializePushNotificationService(); //está linha é necessário se for utilizar o serviço de push notification, aqui é feito o registro automático dos eventos de push;


Grammar error: "está" should be "esta" (without accent). The correct phrase is "esta linha é necessária".

Suggested change

await dito.initializePushNotificationService(); //está linha é necessário se for utilizar o serviço de push notification, aqui é feito o registro automático dos eventos de push;

await dito.initializePushNotificationService(); // esta linha é necessária se for utilizar o serviço de push notification, aqui é feito o registro automático dos eventos de push;

package/pubspec.yaml

package/lib/entity/data_payload.dart

Copilot · 2026-01-12T20:59:10Z

package/lib/services/notification_service.dart

 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
+import 'dart:ui';


The import 'dart:ui' is added but never used in this file. Consider removing this unused import to keep the codebase clean.

Suggested change

import 'dart:ui';

- Introduced a new rules file for Flutter development best practices. - Updated notification service to improve event tracking and removed unused Android channel setup. - Streamlined notification handling by integrating data payload processing.

- Introduced a new 'identifier' field in the DataPayload class to enhance data structure. - Updated constructor and JSON serialization methods to accommodate the new field.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

igorgsduarte added 4 commits March 24, 2025 17:36

change notification service on Click handle

cc649a6

refactor message to use firebase mobile by default

fef6cd9

refactor message to use firebase mobile by default

5d20537

update readme

2201cce

igorgsduarte self-assigned this May 22, 2025

igorgsduarte added 2 commits January 12, 2026 17:50

fix: update migration document to ensure proper initialization code c…

239b16f

…orrections

Copilot AI review requested due to automatic review settings January 12, 2026 20:50

Copilot started reviewing on behalf of igorgsduarte January 12, 2026 20:51 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

igorgsduarte and others added 5 commits January 19, 2026 15:54

feat: add identifier field to DataPayload class

33d103d

- Introduced a new 'identifier' field in the DataPayload class to enhance data structure. - Updated constructor and JSON serialization methods to accommodate the new field.

Apply suggestion from @Copilot

0fdbb80

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

2a1e143

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

22e9ffc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat new push notification approach#25

Feat new push notification approach#25
igorgsduarte wants to merge 11 commits intomainfrom
feat/new-push-approach

igorgsduarte commented May 22, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		final data = DataPayload.fromJson(jsonDecode(message.payload!));

-      final data = DataPayload.fromJson(jsonDecode(message.payload!));
+      final payload = message.payload;
+      if (payload == null) {
+        return;
+      }
+      final data = DataPayload.fromJson(jsonDecode(payload));

	await dito.initializePushNotificationService(); //está linha é necessário se for utilizar o serviço de push notification, aqui é feito o registro automático dos eventos de push;
	await dito.initializePushNotificationService(); // esta linha é necessária se for utilizar o serviço de push notification, aqui é feito o registro automático dos eventos de push;

Conversation

igorgsduarte commented May 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant