This repository was archived by the owner on Jun 20, 2018. It is now read-only.
Open
Conversation
When the switch name has spaces it is not possible to add conditions to make the switch selective. When adding underscores it works properly though. I have not investigated the nexus code base but I figured updating the documentation made sense.
adamchainz
pushed a commit
to adamchainz/gargoyle
that referenced
this pull request
Feb 12, 2016
Fixes the issue reported in disqus#98, thanks @arnaudlimbourg. Turns out that the rows were being assigned HTML ID's, which are not allowed to feature spaces, however this is unneccesary since we only use the `data-` attributes to reference the HTML.
Contributor
|
Fixed using spaces in Switch keys on the YPlan fork in YPlan/gargoyle#38 , thanks for the report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the switch name has spaces it is not possible to add conditions to make the switch selective. When adding underscores it works properly though.
I have not investigated the nexus code base but I figured updating the documentation made sense.