This repository was archived by the owner on Jun 20, 2018. It is now read-only.
Open
Conversation
Fix Range condition
1 task
adamchainz
pushed a commit
to adamchainz/gargoyle
that referenced
this pull request
Jan 29, 2016
Merges disqus#55, thanks @matclayton. Added tests for `Range` by constructing a `ConditionSet` and testing the range on that - the test fails before this patch.
adamchainz
pushed a commit
to adamchainz/gargoyle
that referenced
this pull request
Jan 29, 2016
Merges disqus#55, thanks @matclayton. Added tests for `Range` by constructing a `ConditionSet` and testing the range on that - the test fails before this patch.
pombredanne
pushed a commit
to pombredanne/gargoyle
that referenced
this pull request
Sep 17, 2016
Fixes disqus#55. The API the frontend uses is untested, maybe some tests would have caught it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Range conditions were silently failing, this fixes them.